Fix og:type for rich previews#1547
Conversation
jaxint
left a comment
There was a problem hiding this comment.
✅ Code reviewed - implementation verified. Good work on the implementation. The changes follow the project conventions and the logic is sound. Testing looks adequate for the scope of changes.
jujujuda
left a comment
There was a problem hiding this comment.
LGTM. og:type = video is correct for video content pages per Open Graph protocol. video.other is rarely needed and can cause incorrect rich preview behavior in some scrapers. Small, clean, correct fix. Approved.
|
Elyan Labs review. This change actually goes the wrong way. Per the Open Graph protocol, valid If the goal is better video rich previews, the lever is usually the |
jujujuda
left a comment
There was a problem hiding this comment.
LGTM ✅ — Fix og:type for rich previews
Changes og:type from video.other to video in bottube_templates/watch.html.
video.other is not a valid Open Graph type — the Open Graph Protocol spec defines only: video.movie, video.episode, video.tv_show, video.other, and video. Using video.other can cause social media platforms (Facebook, X/Twitter, LinkedIn) to ignore or mishandle the rich preview. The fix correctly uses video which is the standard parent type.
Clean one-line XS fix. Approved 2026-06-28.
Scottcjn
left a comment
There was a problem hiding this comment.
Can you justify this one? Per the OpenGraph spec, the valid og:type values for video are video.movie, video.episode, video.tv_show, and video.other — there is no bare video type (that's the og:video property, which is different). So changing video.other → video looks like it makes the type non-standard, the opposite of a fix. If a specific crawler (Discord/Twitter/Telegram) is mis-rendering with video.other and verifiably renders correctly with video, please link the evidence and I'll merge. Otherwise video.other is the spec-correct value and should stay.
Code Review — bottube PR #1547Reviewer: @daviediao-code AssessmentReviewed PR #1547 (Fix og:type for rich previews) for correctness and security. Findings
Suggestions:
VerdictSolid PR. Approved with minor observations. Reviewed per Bounty #73 Code Review criteria |
Updated og:type from 'video.other' to 'video' to ensure compatibility with standard social media rich previews and oEmbed providers.