Skip to content

fix: show warning instead of validation error on WIP settings tabs#355

Merged
lane711 merged 1 commit into
mainfrom
fix-settings-save-button
Dec 2, 2025
Merged

fix: show warning instead of validation error on WIP settings tabs#355
lane711 merged 1 commit into
mainfrom
fix-settings-save-button

Conversation

@lane711

@lane711 lane711 commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes the "Save All Changes" button showing confusing "Site name and description are required" error on non-General settings tabs
  • Now shows a warning notification explaining that saving is not yet available for WIP tabs (Appearance, Security, Notifications, Storage)
  • General tab continues to work as expected

Root Cause

The saveAllSettings() function was always routing to /admin/settings/general regardless of the active tab. When on non-General tabs, the form didn't contain siteName or siteDescription fields, causing backend validation to fail.

Changes

Added a check in saveAllSettings() that:

  1. Maintains a list of tabs with implemented save functionality
  2. Shows a helpful warning notification for WIP tabs instead of attempting to save
  3. Only proceeds with save when on a tab with working save endpoint

Test plan

  • Navigate to Admin > Settings > General tab, make changes, click "Save All Changes" - should save successfully
  • Navigate to Admin > Settings > Appearance tab, click "Save All Changes" - should show warning notification
  • Repeat for Security, Notifications, and Storage tabs - all should show warning
  • Migrations and Database Tools tabs have their own action buttons, so "Save All Changes" should show warning there too

Fixes #345

🤖 Generated with Claude Code

The Save All Changes button in Admin Settings was triggering a confusing
"Site name and description are required" error when clicked on non-General
tabs because all tabs routed to the /general endpoint which validates
those fields.

Now the saveAllSettings() function checks if the current tab has save
functionality implemented. For WIP tabs (Appearance, Security, Notifications,
Storage), it shows a warning notification explaining that saving is not yet
available for that section.

Fixes #345

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@lane711 lane711 merged commit 1431945 into main Dec 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin / Settings > unable to Save All Changes

1 participant