fix: show warning instead of validation error on WIP settings tabs#355
Merged
Conversation
The Save All Changes button in Admin Settings was triggering a confusing "Site name and description are required" error when clicked on non-General tabs because all tabs routed to the /general endpoint which validates those fields. Now the saveAllSettings() function checks if the current tab has save functionality implemented. For WIP tabs (Appearance, Security, Notifications, Storage), it shows a warning notification explaining that saving is not yet available for that section. Fixes #345 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The
saveAllSettings()function was always routing to/admin/settings/generalregardless of the active tab. When on non-General tabs, the form didn't containsiteNameorsiteDescriptionfields, causing backend validation to fail.Changes
Added a check in
saveAllSettings()that:Test plan
Fixes #345
🤖 Generated with Claude Code