fix: admin content form and settings improvements#356
Merged
Conversation
Remove the incorrectly nested <script> tags wrapping TinyMCE and MDXEditor initialization scripts. These were already inside an existing <script> block (starting at line 427), causing: - SyntaxError: Unexpected token '<' when adding new content - "[Quill] Found 0 editor containers" - cascading effect - "previewContent is not defined" - cascading effect Fixes #351 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove "Reset to Defaults" button from header - Remove global "Save All Changes" button from header - Add Save button to General settings tab (functional) - Add disabled Save button to WIP tabs (Appearance, Security, Notifications, Storage) with visual indication - Migrations and Database Tools tabs retain their existing action buttons (not settings forms) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add predev script that checks if node_modules/@sonicjs-cms exists and runs npm install if not. This fixes issues when working in git worktrees where workspace symlinks aren't automatically set up. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Adds `npm run workspace` that runs npm install and db:reset, useful for initializing a new worktree environment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lane711
changed the title
Resolve conflict in admin-settings.template.ts by keeping our per-tab save button approach instead of main's saveAllSettings with tab validation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run workspacecommand for fresh setupChanges
1. Fix nested script tags (fixes #351)
Remove incorrectly nested
<script>tags wrapping TinyMCE and MDXEditor initialization scripts. These were already inside an existing<script>block, causing:SyntaxError: Unexpected token '<'when adding new content[Quill] Found 0 editor containers- cascading effectpreviewContent is not defined- cascading effect2. Settings page improvements
3. Workspace setup fixes
predevscript that auto-runsnpm installif workspace symlinks are missingnpm run workspacecommand that runsnpm install && npm run db:resetTest plan
npm run workspaceworks in fresh worktreeFixes #351
🤖 Generated with Claude Code