Feature/client test experiment#10069
Draft
eliandoran wants to merge 5 commits into
Draft
Conversation
Contributor
|
🖥️ App preview is ready! 🔗 Preview URL: https://pr-10069.trilium-app.pages.dev ✅ All checks passed This preview will be updated automatically with new commits. |
Bundle ReportChanges will decrease total bundle size by 25.95kB (-0.03%) ⬇️. This is within the configured threshold ✅ Detailed changes
ℹ️ *Bundle size includes cached data from a previous commit Affected Assets, Files, and Routes:view changes for bundle: client-esmAssets Changed:
view changes for bundle: standalone-esmAssets Changed:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive unit tests (*.spec.tsx) for various Preact widgets, collections, and dialogs in the client application, along with updated documentation and shared test helpers (mocks.ts, render.tsx, setup.ts) to streamline test writing. The feedback recommends importing createContext from from "preact" at the top level of column.spec.tsx and using it directly inside the hoisted vi.mock factory instead of require("preact") to prevent potential Preact instance mismatch and context resolution failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+1
to
+2
| import { act } from "preact/test-utils"; | ||
| import { beforeEach, describe, expect, it, vi } from "vitest"; |
Contributor
There was a problem hiding this comment.
To support using createContext directly in the hoisted vi.mock factory (and avoid potential context mismatch issues from require("preact")), import createContext from "preact" at the top level.
Suggested change
| import { act } from "preact/test-utils"; | |
| import { beforeEach, describe, expect, it, vi } from "vitest"; | |
| import { createContext } from "preact"; | |
| import { act } from "preact/test-utils"; | |
| import { beforeEach, describe, expect, it, vi } from "vitest"; |
Comment on lines
+13
to
+15
| vi.mock(".", () => { | ||
| const { createContext: cc } = require("preact"); | ||
| const BoardViewContext = cc(undefined); |
Contributor
There was a problem hiding this comment.
Using require("preact") inside a hoisted vi.mock factory can lead to multiple instances of Preact being loaded or mismatched context objects, causing useContext(BoardViewContext) to silently fail (returning undefined instead of the provided value). To ensure context resolution works reliably and consistently with other test files (like card.spec.tsx), use the top-level imported createContext directly.
Suggested change
| vi.mock(".", () => { | |
| const { createContext: cc } = require("preact"); | |
| const BoardViewContext = cc(undefined); | |
| vi.mock(".", () => { | |
| const BoardViewContext = createContext(undefined); |
❌ 31 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.