Conversation
adavis10
approved these changes
May 7, 2026
adavis10
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good. I think merging into main is fine b/c we're not changing any of the documentation so the monthly scans won't pull anything not ready for public release into the scheduled updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discrepancy was caused by a tail-direction error in the exact and permutation p-value calculations. The JT statistic increases as the evidence for an increasing trend gets stronger. Therefore, the increasing alternative should use the upper tail of the null distribution, P(J ≥ observed J), while the decreasing alternative should use the lower tail, P(J ≤ observed J). The code was effectively using the opposite tail for the permutation method, and the exact method was similarly misaligned with the statistic direction. As a result, datasets with a very strong increasing trend produced p-values near 1 instead of near 0. The approximate method used the expected direction, which is why it produced the statistically sensible result.