Skip to content

Block link-local addresses in wp_http_validate_url()#12266

Open
tanjiroK-coder wants to merge 2 commits into
WordPress:trunkfrom
tanjiroK-coder:http-api-block-link-local-ssrf-range
Open

Block link-local addresses in wp_http_validate_url()#12266
tanjiroK-coder wants to merge 2 commits into
WordPress:trunkfrom
tanjiroK-coder:http-api-block-link-local-ssrf-range

Conversation

@tanjiroK-coder

Copy link
Copy Markdown

wp_http_validate_url() is the validation layer used by WordPress's safe HTTP API (wp_safe_remote_get(), wp_safe_remote_post(), and related functions) to prevent requests to internal network destinations.

While the existing implementation blocks loopback and RFC1918 private address ranges, it does not reject the IPv4 link-local range (169.254.0.0/16).

This allows URLs resolving to addresses such as 169.254.169.254 (commonly used by cloud metadata services) to pass validation.

Changes

  • Add validation logic to reject addresses in the 169.254.0.0/16 link-local range.

  • Update the function documentation to include the newly blocked range.

  • Add regression tests covering:

    • 169.254.169.254
    • 169.254.1.1

Impact

The link-local range is reserved for local network communication and should not be reachable through APIs intended to protect against SSRF.

Blocking this range aligns its handling with other reserved internal address ranges already denied by wp_http_validate_url() and prevents requests to cloud metadata endpoints from bypassing existing SSRF protections.

@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @tanjiroK-coder.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant