feat: add --ssh-private-key arg for custom SSH key authentication#315
Merged
Conversation
Adds --ssh-private-key argument (equivalent to ssh -i) to allow users to specify a custom private key file for SSH authentication when performing remote backups. The key is passed to paramiko's SSHClient.connect() via the key_filename parameter. Addresses: abbbi#311
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--ssh-private-keyargument (equivalent tossh -i) to allow users to specify a custom private key file for SSH authentication when performing remote backups.Changes
--ssh-private-keyargument to the remote backup options groupSSHClient.connect()to acceptkey_filenameparameter, which is passed to paramiko'sSSHClient.connect()only when specifiedsshSession()to passssh_private_keyfrom args to the SSH client constructorUse case
Users with custom SSH keys stored on encrypted storage (as described in #311) can now run: