fix config adjustment when using data_file with block device#317
Open
bensonbbarry wants to merge 2 commits into
Open
fix config adjustment when using data_file with block device#317bensonbbarry wants to merge 2 commits into
bensonbbarry wants to merge 2 commits into
Conversation
Owner
|
hi, thanks, but fails in code format test: https://github.com/abbbi/virtnbdbackup/actions/runs/28385204851/job/84105978699?pr=317 code should be formatted using black 25.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs in config adjustment and libvirt XML datastore backend handling.
Changes
Issue 1:
dataFilePathundefined whenadjust_configis FalsedataFilePathwas only assigned inside theif adjust_configblock, causingan
UnboundLocalErrorwhen the variable was referenced later withadjust_config=FalsedataFilePath = dataFilebefore the conditional blockIssue 2: Block device backend fails during libvirt XML datastore adjustment
fileandblockbackends aresupported correctly
Testing
adjust_config=False— no longer raisesUnboundLocalError