chore: change from delayed flow to include consent#376
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
davidnuescheler
changed the title
davidnuescheler
changed the title
delayed flow to include consent
| if (consentStatus === 'declineAll') return false; | ||
| return true; |
There was a problem hiding this comment.
| if (consentStatus === 'declineAll') return false; | |
| return true; | |
| if (consentStatus === 'acceptAll') return true; | |
| return false; |
| if (consentStatus !== null) return mapStatus(consentStatus); | ||
| return new Promise((resolve) => { | ||
| // display consent banner | ||
| document.addEventListener('aem:changeconsent', (e) => { |
There was a problem hiding this comment.
| document.addEventListener('aem:changeconsent', (e) => { | |
| document.addEventListener('aem:consentchange', (e) => { |
There was a problem hiding this comment.
Actually, who fires this event ? Adding an event listener in a check method is not a good practice. If I call the checkConsent method multiple times, the document will have multiple similar listeners.
|
Hi @davidnuescheler - I've updated this branch to resolve merge conflicts with Changes Made✅ Simplified ✅ Added null check for missing fragment - Now handles missing consent banner fragment, defaulting to Remaining Questions
Status CheckThis PR has been open since June 2024. Are you still interested in pursuing this consent flow approach, or should we close this in favor of a different solution? |
5 participants
changing the flow of loading marketing tech based on a conditions / events such as consent
https://marketing-tech--aem-boilerplate--adobe.aem.page/