UCX: provide an option to enable/disable UCX rcache#1762
Conversation
|
👋 Hi ZhenlongMa! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR adds a build-time configuration option to selectively enable or disable UCX registration caching. A new ChangesUCX Registration Cache Feature Gating
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi reviewers, |
|
LGTM |
What?
Disable UCX registration caches by default in the UCX backend.
Why?
NIXL always passes the local memory handle (
memh) explicitly to UCX operations, so UCX does not need to rely on memory hooks for this path.Installing memory hooks is intrusive and can lead to correctness or stability issues, especially for dynamic memory workloads. Disabling rcache by default avoids installing those hooks while preserving the existing explicit memory registration flow.
How?
This PR adds a build-time
enable_rcacheMeson option. When it is not set, NIXL configures UCX with:RCACHE_ENABLE=nGDR_COPY_RCACHE=nROCM_COPY_RCACHE=nso that all kinds of rcache are disabled.
Summary by CodeRabbit