Skip to content

rightMenu#88

Open
wangchangqi01 wants to merge 4 commits into
alibaba:masterfrom
wangchangqi01:wcq_butter
Open

rightMenu#88
wangchangqi01 wants to merge 4 commits into
alibaba:masterfrom
wangchangqi01:wcq_butter

Conversation

@wangchangqi01

Copy link
Copy Markdown

rightMenu

@CLAassistant

CLAassistant commented Mar 7, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wb-wcq372632 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment thread src/canvas/baseCanvas.less Outdated
}
}

.endpoint-tips-menu{

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个menu应该是能支持所有的节点,名字有问题

Comment thread src/service/sevice.js Outdated
const _ = require('lodash');


function createMenuList(param, callBack, e) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抽象库不能这样写。。。event是业务或者外部耦合的,不应该传进来处理

Comment thread src/service/sevice.js Outdated
top: evt.clientY
};
if (param.type === 'tips') {
$(document.body).find('.endpoint-tips-menu').remove();

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个使用方法上有问题

Comment thread src/service/sevice.js Outdated
left: evt.clientX,
top: evt.clientY
};
if (param.type === 'tips') {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我建议分开2个方法吧,不要耦合在一起

Comment thread index.js Outdated
Group,
Node
Node,
ServiceCanvas

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该叫MenuService

wb-wcq372632 added 2 commits March 7, 2019 17:11
Comment thread src/service/sevice.js
const $ = require('jquery');
const _ = require('lodash');

class MenuService {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我不太建议写成clasa,假如用户想使用的话,应该比较简单地let menuSrevices = require('xxx');menuSrevices.shou(xxx);这样比较清爽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants