Hyphenation on line-broken text#3193
Conversation
Compose file was missing a restart policy for reactive-resume service, which was causing the service to not restart during docker restarts
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds locale-aware Latin hyphenation to the PDF rendering pipeline using the ChangesLocale-aware Latin Hyphenation
Docker Restart Policy
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/pdf/src/hyphen.d.ts`:
- Around line 1-15: The module declarations in hyphen.d.ts should match the
published locale import subpaths, not the internal index.js paths. Update the
declarations for the hyphenator module aliases used by the PDF package to target
hyphen/da and hyphen/en-us directly, and keep the default export shape the same
so TypeScript resolves the same imports exposed by the package exports map.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ce108460-9bc0-4fc3-bb35-8edf9aad1c56
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
compose.ymlpackages/pdf/package.jsonpackages/pdf/src/hooks/use-register-fonts.test.tspackages/pdf/src/hooks/use-register-fonts.tspackages/pdf/src/hyphen.d.ts
Long words were not wrapping properly on cells and lacked automatic hyphenation.
For now it only involves english and danish hyphenation as those are my main languages. You are welcome to add your languages or modify for a more general-purpose hyphenation across all languages
A section element title being hyphenated due to its length

A section element text being hyphenated due to the cell size

Summary by CodeRabbit