feat(frontend): rework rejection note dialog (ARG-444)#2336
Merged
gregberge merged 2 commits intoJul 5, 2026
Merged
Conversation
The "Add a note about this rejection" dialog now: - shows a normal "Add to review" button in the footer instead of a send button baked into the editor field - displays the target snapshot (thumbnail + name) above the field so the reviewer sees what they're commenting on - after submit, opens the review panel (so the new comment is visible) and advances to the next snapshot so the reviewer can keep going The provider/context/hook API is unchanged, so TrackButtons and BuildPage need no changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
gregberge
commented
Jul 5, 2026
…nt it Address PR review feedback: - Replace useMutation with useApolloClient().mutate(). useMutation subscribes the component to the mutation's own state and re-renders it while the request is in flight even though that state is never read here. - Drive the modal's pending state via ModalActionContext (as a dialog Form does) so the footer buttons disable and the modal can't be dismissed while submitting — restoring the disabled-while-submitting behavior. - Document the useMutation vs client.mutate guidance in apps/frontend/AGENTS.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gregberge
deleted the
greg/arg-444-change-this-dialog-to-have-normal-button-in-the-footer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the "Add a note about this rejection" dialog (shown when rejecting a snapshot during build review) per ARG-444.
Empty submit still surfaces the "Comment required" toast, and content is preserved on error. The provider/context/hook API is unchanged, so
TrackButtons/BuildPageneed no changes.Notes
Test plan
🤖 Generated with Claude Code