feat(frontend): show previous approvals dialog on overview (ARG-443)#2337
Merged
gregberge merged 1 commit intoJul 5, 2026
Conversation
Move the "Previous approvals detected" dialog from the review view to the build overview so it appears as soon as the user arrives. Accepting still reapplies the approvals and redirects to the first snapshot to review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
gregberge
deleted the
greg/arg-443-previous-approvals-detected-dialog-not-shown-on-overview
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARG-443
The "Previous approvals detected" dialog was only shown once the user entered the review flow. It now appears as soon as the user arrives on the build overview.
The dialog logic itself was already correct — it opens only when there are previous branch approvals to reapply, the viewer hasn't submitted a review, and no diffs have been marked yet; and on Reapply it reapplies the approvals and redirects to the first still-pending snapshot. The only issue was where it was mounted.
Changes
<BuildDialogs>render, its import, and the...BuildDialogs_Buildfragment spread (this is what delayed the dialog until review mode).<BuildDialogs>here and added...BuildDialogs_Buildto theBuildOverview_Buildfragment.Behavior
🤖 Generated with Claude Code