fix(frontend): size text snapshot editor to content (ARG-454)#2350
Merged
Conversation
The single text/ARIA snapshot editor sits in a row flex container whose default `align-items: stretch` stretched the bordered viewer to the full panel height, leaving a large empty box for short snapshots. Wrap it in a `w-full self-start` div so it sizes to its content; the outer panel is already `overflow-y-auto`, so tall snapshots still scroll. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the build review, a text/ARIA snapshot editor stretched to fill the entire viewport height even when it contained just one line (e.g.
button "Click me"), leaving a large empty bordered box.Root cause
The single text snapshot editor (
Snapshot→Editor, used forAdded/Unchanged/baseline text diffs) is rendered inside a row flex container (flex ... justify-center). The defaultalign-items: stretchstretched the bordered@pierre/diffsviewer to the full panel height. The multi-line Changed diff didn't have this issue because it lives in a column flex, where it already sizes to content.Fix
Wrapped the editor in a
w-full self-startdiv so it opts out of the row's vertical stretch and sizes to its content. The outer detail panel is alreadyoverflow-y-auto, so tall snapshots still scroll — matching how the Changed diff already behaves.Resolves ARG-454.
🤖 Generated with Claude Code