Skip to content

fix(ec): rayon::ThreadPoolBuilder panic in wasm32 #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weikengchen merged 4 commits into from
Jun 20, 2026
+4 −2
Merged

fix(ec): rayon::ThreadPoolBuilder panic in wasm32 #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b41794b
fix(ec): rayon::ThreadPoolBuilder panic in wasm32
Robert-MacWha Jun 15, 2026
0bb39a5
chore: update CHANGELOG.md
Robert-MacWha Jun 15, 2026
a2af74c
lint: style
Robert-MacWha Jun 16, 2026
87be115
chore: fix changelog typo
weikengchen Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- [\#1039](https://github.com/arkworks-rs/algebra/pull/1039) (`ark-ff-asm`) Remove unused dead spill buffer path.
- [\#1044](https://github.com/arkworks-rs/algebra/pull/1044), [\#1084](https://github.com/arkworks-rs/algebra/pull/1084), [\#1088](https://github.com/arkworks-rs/algebra/pull/1088) Add implementation for small field with native integer types
- [\#1061](https://github.com/arkworks-rs/algebra/pull/1061) (`ark-poly`) Reduce allocations in `DenseMultilinearExtension::{concat, fix_variables, evaluate}`.
- [\#1112](https://github.com/arkworks-rs/algebra/pull/1112) (`ark-ec`) Fix rayon::ThreadPoolBuilder panicking in wasm32 when parallel feature is enabled

### Breaking changes

Expand Down
5 changes: 3 additions & 2 deletions ec/src/scalar_mul/variable_base/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,14 +542,15 @@ fn msm_bigint_wnaf<V: VariableBaseMSM>(
cfg_chunks!(bases, chunk_size)
.zip(cfg_chunks!(scalars, chunk_size))
.map(|(bases, scalars)| {
#[cfg(feature = "parallel")]
// wasm32 can't spawn OS threads
#[cfg(all(feature = "parallel", not(target_arch = "wasm32")))]
let result = rayon::ThreadPoolBuilder::new()
.num_threads(THREADS_PER_CHUNK.min(rayon::current_num_threads()))
.build()
.unwrap()
.install(|| msm_bigint_wnaf_parallel::<V>(bases, scalars));

#[cfg(not(feature = "parallel"))]
#[cfg(any(not(feature = "parallel"), target_arch = "wasm32"))]
let result = msm_bigint_wnaf_parallel::<V>(bases, scalars);

result
Expand Down
Loading