Make gensim optional#49
Closed
timovdk wants to merge 14 commits into
Closed
Conversation
Member
|
This doesn't propagate nicely to the GUI and will result in unexpected behavior for frontend users, I expect. Not sure if this aligns with the package's proposed architecture and paper. Can you confirm? |
Collaborator
Author
|
Hmm the idea is to not depend on gensim updates for major Python releases because they are always slow to update. But we do need it for an optimized implementation of Doc2Vec. Hence, the optional import seemed like the best of bad options, since now people run into issues when trying to install asreview dory on Py3.14, because Gensim is not updated yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make Dory work on Python 3.14 I propose to make gensim optional