feat(telegram): Add voice transcript echo#169
Open
ddobrinskiy wants to merge 8 commits into
Open
Conversation
ddobrinskiy
changed the title
ddobrinskiy
changed the title
Add inline documentation explaining the UX rationale and implementation details for the voice transcript reaction feature: - Document why visual feedback happens before prompt processing - Explain formatting choices (emoji header, italic body) - Add Given/When/Then structure to tests for clarity - Note edge cases: empty transcripts, truncation, silent notifications Files updated: - bridge.py: docstring and inline comments for send_voice_transcript() - loop.py: comments explaining the UX flow - test_telegram_bridge.py: structured test documentation
Update documentation to reflect the new transcript reply feature: - Add behavior description to voice-notes.md explaining the 🎤 header and italic formatting that shows transcript before running - Update telegram.md transport reference with details about the visual feedback message sent before transcription runs This documents the UX improvement where users see their transcribed voice message as a reply before the actual run starts.
ddobrinskiy
force-pushed
the
feat/voice-transcript-reaction
branch
from
019cee6 to
80e2b0a
Compare
Author
|
@banteg ready for review, wdyt? |
Add configurable voice transcript echo behavior: - New setting `voice_transcription_echo: bool = true` in settings.py - Echo sends transcript as reply with 🎤 emoji header (enabled by default) - Users can disable with `voice_transcription_echo = false` Implementation: - Added to TelegramTransportSettings, TelegramBridgeConfig - Wired through backend.py to bridge/loop - Conditional check in loop.py before sending transcript reply Documentation: - Updated config.md reference table - Updated voice-notes.md with config examples and behavior notes - Updated telegram.md transport reference with echo details Tests: - Updated existing voice transcript tests to use echo=True - Added new test for echo=False to verify no message sent - Updated backend test with new config assertion Inspiration: banteg#196 by @heswithme Thanks for the idea to make echo behavior configurable! Differs from upstream PR banteg#196: - Default: true (enabled) vs false (upstream) - Format: 🎤 emoji + italics (better UX) vs code + blockquote - Implementation: bridge.py helper vs loop.py inline
ddobrinskiy
force-pushed
the
feat/voice-transcript-reaction
branch
from
80e2b0a to
5346b70
Compare
Remove the planning document that was created during development but shouldn't be part of the final PR.
ddobrinskiy
changed the title
ddobrinskiy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🎤 · voice transcriptand render the transcript in italicsTelegram UI