optimize PGN parsing process and improve perfomance#133
Open
TaehyeonEntus wants to merge 5 commits into
Open
Conversation
The previous isEndGame only invoked updateCommentState when the current
line already ended with a result token, so a '{' opening a multi-line
comment on a non-result line was never recorded. A subsequent line
ending in 1-0/0-1/1/2-1/2/* would then be treated as the game end even
though it sat inside the open comment.
Update the state unconditionally and short-circuit when a comment is
open. Also guard the '}' branch so a stray closer outside a comment
cannot flip state. Adds two regression tests for multi-line comments
spanning result tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[perf: replace StringBuffer with StringBuilder]
[perf: reduce String objects in parsePgnProperty]
[perf: replace pattern matcher with boolean expressions]
[perf: replace int depth with boolean value in isEndGame]
I passed every test cases.
PS . Always thanks for your library!!