Fix test_env leaking config overrides into other tests#898
Merged
Conversation
test_env set os.environ MINIWDL_CFG (to a delete=False temp config with
copy_input_files=true), MINIWDL__SCHEDULER__TASK_CONCURRENCY, and
MINIWDL__BOGUS__OPTION without ever restoring them or removing the temp file.
Under pytest-xdist a worker runs many tests in one process, so the leaked
MINIWDL_CFG caused later tests' config Loaders to pick up copy_input_files=true
-- which made test_7runner's source-relative file_io.root assertions stop
raising ("InputError not raised"), order-dependently.
Restore the environment and unlink the temp file via addCleanup so the test is
hermetic. (test_7runner Loaders were independently hardened to ignore config
files; this removes the leak at its source, including the env overrides that an
empty filenames list does not suppress.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Coverage Report for CI Build 28280636726Coverage remained the same at 95.86%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
mlin
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.