fix(style): support 3-value padding/margin shorthand#1089
Open
s3onghyun wants to merge 1 commit into
Open
Conversation
ParsePadding handled 1, 2, and 4 tokens but had no branch for 3, so 'gum style --padding "1 2 3"' fell through to (0,0,0,0) and rendered with no padding. lipgloss supports the 3-arg CSS shorthand (top / horizontal / bottom), so add the missing branch. Signed-off-by: Seonghyun Hong <s3onghyun.hong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--padding/--marginwith 3 values being silently ignored.ParsePadding(style/spacing.go) handled 1, 2, and 4 tokens but had no branch for 3, sogum style --padding "1 2 3" "text"fell through to(0,0,0,0)and rendered with no padding.(top, horizontal, bottom, horizontal).style/spacing_test.gowith a table test forParsePadding(1/2/3/4 tokens). The 3-token case fails before this change and passes after;go test ./...green.