Skip to content

(jubler) Switch to GitHub release assets and drop 32-bit#2727

Draft
AdmiringWorm wants to merge 2 commits into
chocolatey-community:masterfrom
AdmiringWorm:jubler-use-https-urls
Draft

(jubler) Switch to GitHub release assets and drop 32-bit#2727
AdmiringWorm wants to merge 2 commits into
chocolatey-community:masterfrom
AdmiringWorm:jubler-use-https-urls

Conversation

@AdmiringWorm

@AdmiringWorm AdmiringWorm commented Sep 18, 2025

Copy link
Copy Markdown
Member

Description

  • Switched download, project, and changelog URLs from HTTP to HTTPS in metadata and updater.
  • Updated autoupdate and installer scripts to use GitHub release assets (browser_download_url and digest) instead of scraping the downloads page.
  • Removed handling for a non-existent 32-bit build (set 32-bit installer path empty; use x64 only).

Motivation and Context

  • Improve security and avoid mixed-content/redirect issues by using HTTPS links.
  • Make updates more robust and authoritative by relying on GitHub release metadata (prevents broken updates from missing 32-bit artifacts).

How Has this Been Tested?

  • Manual running of the .\update_all.ps1 jubler to ensure package is updated correctly.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My pull request is not coming from the master branch.
  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment. Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@JPRuskin JPRuskin self-requested a review September 18, 2025 14:51
JPRuskin
JPRuskin previously approved these changes Sep 18, 2025

@JPRuskin JPRuskin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

That said, it seems to be timing out on the installation on AppVeyor.

@AdmiringWorm

Copy link
Copy Markdown
Member Author

Seems like perhaps the installation of the package is broken. Need to have a look at that at a later date.

Avoid merging this PR it has been fixed (anyone seeing this message are free to create a PR despite this one existing).

@AdmiringWorm AdmiringWorm marked this pull request as draft September 18, 2025 15:30
@AdmiringWorm AdmiringWorm self-assigned this Sep 30, 2025
@pauby

pauby commented Oct 30, 2025

Copy link
Copy Markdown
Member

@AdmiringWorm have you looked at the failures?

@AdmiringWorm

Copy link
Copy Markdown
Member Author

@AdmiringWorm have you looked at the failures?

Not had the chance yet, hoping to get to it today.

Update Jubler metadata and updater script use HTTPS URLs
instead of HTTP. Change the release page in automatic/jubler/update.ps1
to https://jubler.org/download.html and update the projectUrl and
changelog links in automatic/jubler/jubler.nuspec to secure
https://www.jubler.org/... and https://www.jubler.org/changelog.html.

This improves security and avoids mixed-content or redirect issues when
retrieving release information and package metadata.
Update Jubler autoupdate and installer scripts to use GitHub release
assets instead of scraping a downloads page, and remove handling for
a missing 32-bit build.

- chocolateyinstall.ps1: set 32-bit file to empty and keep x64 file
  path. This reflects that no 32-bit installer is available.
- update.ps1: refactor au_GetLatest to call Get-GitHubRelease and read
  asset fields (browser_download_url and digest) for version, URL,
  and checksum. Remove URL32/FileName32 and 32-bit checksum fields and
  update replacements to use 64-bit checksum/type and file names.
- update.ps1: simplify update invocation to call update -ChecksumFor none
  and remove brittle web scraping and error-catching logic.

This makes the update flow more robust, uses authoritative GitHub
metadata for checksums and download URLs, and prevents broken updates
for a non-existent 32-bit installer.
@AdmiringWorm AdmiringWorm changed the title (jubler) Switch to HTTPS for download, project, changelog (jubler) Switch to GitHub release assets and drop 32-bit Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants