Skip to content

Request #1207#1209

Open
YoanThomasPhd wants to merge 1 commit into
chocoteam:developfrom
YoanThomasPhd:fix-seed
Open

Request #1207#1209
YoanThomasPhd wants to merge 1 commit into
chocoteam:developfrom
YoanThomasPhd:fix-seed

Conversation

@YoanThomasPhd

Copy link
Copy Markdown

Move seed from Model and RegParser to Settings and SettingsBuilder.

The seed is now accessible via model.getSettings().getSeed(). After initialization, the seed can no longer be changed.

Move seed from Model and RegParser to Settings and SettingsBuilder.

The seed is now accessible via model.getSettings().getSeed().
After initialization, the seed can no longer be changed.

@ArthurGodet ArthurGodet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifications of code are fine to me. However, since some default values have been changed, some expected values need to be change in tests

@cprudhom

cprudhom commented Jun 9, 2026

Copy link
Copy Markdown
Member

Since dom/wdeg is the default strategy, changing the seed affects a large number of tests.
Before approving the PR, we need to make sure that the differences are indeed caused solely by this (which may take a little time).

@YoanThomasPhd

Copy link
Copy Markdown
Author

I won't have time to check and fix the tests for now, I will try to verify the validity of dom/wdeg and the others later this summer
For now I will assume that everything is valid and use this fix for my tests with different seed!

@mergify

mergify Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants