test(desktop): file-index skips root-level hidden dotfiles (Closes #390)#549
Conversation
Regression test for clawwork-ai#390: scanFolder should exclude `.DS_Store` at the scan root while still indexing allow-listed dotfiles like `.env`.
|
Hi @advancedresearcharray, DetailsInstructions for interacting with me using comments are available here. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a regression test to ensure the file indexing logic correctly handles hidden files at the root directory. By validating that unwanted dotfiles are excluded while critical configuration files remain, the change improves the reliability of the folder scanning process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new test suite to verify that the scanFolder function correctly filters hidden files while preserving allow-listed ones. The feedback suggests adding an existence check for the temporary directory variable in the afterEach cleanup hook to prevent a potential TypeError from masking setup failures if beforeEach fails.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| afterEach(() => { | ||
| rmSync(dir, { recursive: true, force: true }); | ||
| }); |
There was a problem hiding this comment.
If beforeEach fails before dir is assigned (e.g., if mkdtempSync throws), dir will be undefined. Calling rmSync(undefined, ...) in afterEach will throw a TypeError, masking the original setup failure and making debugging harder. It is safer to guard the cleanup with an existence check.
afterEach(() => {
if (dir) {
rmSync(dir, { recursive: true, force: true });
}
});
Closes #390
Summary
Adds a regression test for
scanFolder/walkDirhidden-file filtering at depth 0.The implementation already skips hidden dotfiles at the scan root while keeping allow-listed entries (
.env,.gitignore,.dockerfile).Test plan
pnpm --filter @clawwork/desktop test -- file-index.test.ts