Skip to content

test(desktop): file-index skips root-level hidden dotfiles (Closes #390)#549

Open
advancedresearcharray wants to merge 1 commit into
clawwork-ai:mainfrom
advancedresearcharray:fix/issue-390-file-index-hidden
Open

test(desktop): file-index skips root-level hidden dotfiles (Closes #390)#549
advancedresearcharray wants to merge 1 commit into
clawwork-ai:mainfrom
advancedresearcharray:fix/issue-390-file-index-hidden

Conversation

@advancedresearcharray

Copy link
Copy Markdown
Contributor

Closes #390

Summary

Adds a regression test for scanFolder / walkDir hidden-file filtering at depth 0.

The implementation already skips hidden dotfiles at the scan root while keeping allow-listed entries (.env, .gitignore, .dockerfile).

Test plan

  • pnpm --filter @clawwork/desktop test -- file-index.test.ts

Regression test for clawwork-ai#390: scanFolder should exclude `.DS_Store` at the
scan root while still indexing allow-listed dotfiles like `.env`.
@github-actions

Copy link
Copy Markdown
Contributor

Hi @advancedresearcharray,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a regression test to ensure the file indexing logic correctly handles hidden files at the root directory. By validating that unwanted dotfiles are excluded while critical configuration files remain, the change improves the reliability of the folder scanning process.

Highlights

  • Regression Testing: Added a new test suite to verify that hidden dotfiles are correctly filtered at the root level during folder scanning.
  • Filtering Logic: Ensured that while standard hidden files like .DS_Store are skipped, allow-listed files such as .env are preserved.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test suite to verify that the scanFolder function correctly filters hidden files while preserving allow-listed ones. The feedback suggests adding an existence check for the temporary directory variable in the afterEach cleanup hook to prevent a potential TypeError from masking setup failures if beforeEach fails.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +17 to +19
afterEach(() => {
rmSync(dir, { recursive: true, force: true });
});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If beforeEach fails before dir is assigned (e.g., if mkdtempSync throws), dir will be undefined. Calling rmSync(undefined, ...) in afterEach will throw a TypeError, masking the original setup failure and making debugging harder. It is safer to guard the cleanup with an existence check.

  afterEach(() => {
    if (dir) {
      rmSync(dir, { recursive: true, force: true });
    }
  });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] file-index walkDir does not filter hidden files at the top level

1 participant