fix(graphql): Re-add deprecated coverage totals fields for backward compatibility#1204
Open
sentry[bot] wants to merge 1 commit into
Open
fix(graphql): Re-add deprecated coverage totals fields for backward compatibility#1204sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50862 50865 +3
Branches 1626 1626
=======================================
+ Hits 46741 46744 +3
Misses 3815 3815
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue API-EC9, a
GraphQLError: Cannot query field 'lines' on type 'CoverageTotals'.Root Cause:
The
CoverageTotalsGraphQL type had itslines,hits, andmissesfields renamed tolineCount,hitsCount, andmissesCountrespectively. The old field names were removed from the schema without deprecated aliases, causing a breaking change for clients still querying the old field names.Solution:
This PR re-introduces the
lines,hits, andmissesfields to theCoverageTotalsGraphQL type, marking them as@deprecatedand pointing to their newlineCount,hitsCount, andmissesCountcounterparts. Additionally, identity aliases are added in the Pythoncoverage_totals.pyfile to ensure Ariadne correctly resolves these deprecated fields from the underlying data object attributes.This change restores backward compatibility for existing clients using the old field names, while new clients are encouraged to use the updated field names.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes API-EC9