Skip to content

fix(worker): Resolve N+1 query in ProcessFlakesTask#1207

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-n-plus-1-flakes-JdHNto
Open

fix(worker): Resolve N+1 query in ProcessFlakesTask#1207
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-n-plus-1-flakes-JdHNto

Conversation

@sentry

@sentry sentry Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query performance issue within the ProcessFlakesTask by refactoring the ta_process_flakes.py module.

Previously, the process_flakes_for_commit function iterated over each ReportSession (upload) for a given commit, calling process_single_upload for each. This resulted in an N+1 query pattern where Testrun objects were fetched and updated individually for every upload (one SELECT and one UPDATE per upload).

The fix consolidates these database operations:

  • get_testruns now accepts a list of upload_ids, allowing all relevant testruns across multiple uploads to be fetched in a single SELECT query.
  • The logic from process_single_upload has been integrated into a new process_all_uploads function, which processes all testruns for all uploads in a single pass.
  • The Testrun.objects.bulk_update call is now performed once after all testruns have been processed, resulting in a single UPDATE query.

This change significantly reduces the number of database queries, improving the performance of the ProcessFlakesTask by transforming N SELECTs + N UPDATEs into 1 SELECT + 1 UPDATE.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YTB

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (7b60783) to head (cdc0456).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files        1325     1325              
  Lines       50862    50860       -2     
  Branches     1626     1626              
==========================================
- Hits        46741    46739       -2     
  Misses       3815     3815              
  Partials      306      306              
Flag Coverage Δ
workerintegration 58.57% <40.00%> (+<0.01%) ⬆️
workerunit 90.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants