[fix][backend] populate FieldData key from dataset schema in data reflow#562
Merged
Conversation
Previously, buildItem and buildDatasetItem passed empty string as FieldData.Key when constructing dataset items. This caused: - Evaluation set items to be silently dropped (due to fd.Key != "" filter) - Dataset items to potentially mismatch schema when column names contain CJK characters or spaces Fix by retrieving the real key from dataset/evaluation-set schema: - trace_export_service: use dataset.GetFieldSchemaKeyByName in buildItem - auto_evaluate processor: parse schema JSON from TaskRun config to get real keys via fillDatasetKeysFromSchema, avoiding extra RPC calls
Cover fillDatasetKeysFromSchema (empty/invalid JSON, name match, overwrite, nil key skip), buildItem key propagation, Invoke/BatchInvoke end-to-end key verification, and trace export service key-from-dataset-schema scenario.
kidkidkid
approved these changes
Jun 24, 2026
cuichen01
approved these changes
Jun 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 77.81% 77.82% +0.01%
==========================================
Files 670 670
Lines 76100 76151 +51
==========================================
+ Hits 59217 59268 +51
+ Misses 13421 13419 -2
- Partials 3462 3464 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, buildItem and buildDatasetItem passed empty string as FieldData.Key when constructing dataset items. This caused:
Fix by retrieving the real key from dataset/evaluation-set schema:
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes