make MantleBackup spec.pvc available for field selector#172
Merged
Conversation
Signed-off-by: Yuma Ogami <yuma-ogami@cybozu.co.jp>
There was a problem hiding this comment.
Pull Request Overview
Adds support for using the .spec.pvc field in server-side field selectors for the MantleBackup CRD.
- Includes the new
selectableFieldsentry in both the base CRD and Helm chart template. - Adds a Kubebuilder marker in the Go API type to generate the field selector.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config/crd/bases/mantle.cybozu.io_mantlebackups.yaml | Injects selectableFields: - jsonPath: .spec.pvc into CRD |
| charts/mantle-cluster-wide/templates/mantle.cybozu.io_mantlebackups.yaml | Mirrors the same selectableFields update in chart |
| api/v1/mantlebackup_types.go | Adds //+kubebuilder:selectablefield:JSONPath= marker |
Comments suppressed due to low confidence (3)
config/crd/bases/mantle.cybozu.io_mantlebackups.yaml:151
- [nitpick] Consider adding an integration or e2e test that exercises
kubectl get mantlebackups --field-selector spec.pvc=<value>to verify the new field selector functionality.
selectableFields:
api/v1/mantlebackup_types.go:71
- The Kubebuilder marker for selectable fields appears incorrect. It should use the plural form and correct syntax, for example:
//+kubebuilder:selectableFields:jsonPath=.spec.pvc(without backticks).
//+kubebuilder:selectablefield:JSONPath=`.spec.pvc`
satoru-takeuchi
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add selectableFields of .spec.pvc to the MantleBackup CRD.