Sorting functions for common use#188
Merged
Merged
Conversation
c8a74fc to
7dc4613
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors controller code to extract common functionality into reusable utility functions. Despite the title mentioning "sorting functions," this is actually about organizing and generalizing code by extracting duplicate logic into shared functions.
Key Changes
- Extracted
createCloneByPV()function toutil.gofor creating RBD clone images, eliminating code duplication frommantlerestore_controller.go - Generalized
createOrUpdateZeroOutPV/PVCfunctions intocreateOrUpdateStaticPV/PVCinmantlebackup_controller.gowith parameterized names and components - Removed
slicesimport frommantlerestore_controller.go(moved to util.go with the extracted function)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/controller/util.go | Adds new createCloneByPV() helper function to create RBD clone images from PV snapshots, and imports slices and ceph packages |
| internal/controller/mantlerestore_controller.go | Refactors to use the extracted createCloneByPV() function, simplifying cloneImageFromBackup() and removing duplicate code |
| internal/controller/mantlebackup_controller.go | Renames and generalizes createOrUpdateZeroOutPV/PVC to createOrUpdateStaticPV/PVC with parameterized inputs for broader reusability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
7dc4613 to
2a48360
Compare
6c687d8 to
2a48360
Compare
skoya76
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.