change api CreateOrUpdateMantleBackup to CreateMantleBackup#194
Merged
Conversation
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
llamerada-jp
force-pushed
the
5672-lock-volume-2
branch
2 times, most recently
from
0aeb1d9 to
596dd6f
Compare
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
llamerada-jp
force-pushed
the
5672-lock-volume-2
branch
2 times, most recently
from
8c5dd86 to
a350295
Compare
`ctrl.Result{Requeue: true}` is influenced by backing off. We want
to avoid it.
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
llamerada-jp
force-pushed
the
5672-lock-volume-2
branch
from
a350295 to
33b255f
Compare
After created MB, there is no need to update it. And We Found a bug caused by overwriting existing annotations Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
llamerada-jp
force-pushed
the
5672-lock-volume-2
branch
from
33b255f to
61821f3
Compare
llamerada-jp
changed the title
There was a problem hiding this comment.
Pull request overview
This PR refactors the gRPC API by renaming CreateOrUpdateMantleBackup to CreateMantleBackup, reflecting a change in semantics where the API now only creates backups and explicitly checks for existing backups rather than using create-or-update logic. Additionally, it standardizes the requeue reconciliation mechanism by requiring the REQUEUE_RECONCILIATION_AFTER environment variable and updates test timeouts and logging for better debugging.
- Renamed gRPC API from
CreateOrUpdateMantleBackuptoCreateMantleBackupwith updated semantics that explicitly check for existing backups - Changed
requeueReconciliation()to requireREQUEUE_RECONCILIATION_AFTERenv var (defaulting to "10s" in configs) instead of allowing immediate requeue - Enhanced e2e test debugging by increasing log tail sizes, adding comprehensive resource dumps on failure, and improving test helper logging
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/controller/proto/controller.proto | Renamed RPC method and message types from CreateOrUpdateMantleBackup to CreateMantleBackup |
| pkg/controller/proto/controller.pb.go | Regenerated protobuf Go code for the renamed API |
| pkg/controller/proto/controller_grpc.pb.go | Regenerated gRPC Go code for the renamed API |
| pkg/controller/proto/controller_grpc.pb_mock.go | Updated mock implementation for the renamed API |
| internal/controller/replication.go | Refactored CreateMantleBackup implementation to explicitly check if backup exists before creating, with improved error messages |
| internal/controller/mantlebackup_controller.go | Updated client call from CreateOrUpdateMantleBackup to CreateMantleBackup |
| internal/controller/mantlebackup_controller_test.go | Updated mock expectations and test assertions to use CreateMantleBackup and check RequeueAfter instead of Requeue |
| internal/controller/util.go | Changed requeueReconciliation() to require REQUEUE_RECONCILIATION_AFTER env var and panic if not set |
| internal/controller/suite_test.go | Added REQUEUE_RECONCILIATION_AFTER env var setup in test suite |
| internal/webhook/v1/suite_test.go | Added REQUEUE_RECONCILIATION_AFTER env var setup in test suite |
| test/e2e/multik8s/testutil/util.go | Added GinkgoHelper() call, improved logging with cluster/namespace context, and migrated to HaveLen() matcher |
| test/e2e/multik8s/full_backup_test.go | Migrated test assertions to use HaveLen() matcher and fixed comment capitalization |
| test/e2e/Makefile | Increased log tail from 100 to 1000 lines and added comprehensive resource dumps on test failure |
| test/e2e/testdata/values-mantle-primary-template.yaml | Changed REQUEUE_RECONCILIATION_AFTER value from "1s" to "10s" |
| test/e2e/testdata/values-mantle-secondary-template.yaml | Changed from REQUEUE_RECONCILIATION_IMMEDIATELY to REQUEUE_RECONCILIATION_AFTER with "10s" value |
| docs/controller-protocol.md | Updated documentation to reflect renamed API methods and message types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
satoru-takeuchi
approved these changes
Dec 3, 2025
llamerada-jp
added a commit
that referenced
this pull request
Dec 8, 2025
…ackup-rpc-call Fix bugs introduced in #194
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.