Fix expire not running when target PVC is deleted before backup expires

[llamerada-jp]

No description provided.

[Copilot]

Pull request overview

Fixes MantleBackup expiration handling so backups can still be deleted (or scheduled for deletion) even when the backup’s target PVC disappears before the backup reaches its expiry time.

Changes:

• Update expire to return a boolean indicating whether reconciliation should stop after requesting deletion.
• Invoke expire earlier in reconcileLocalBackup and reconcileAsSecondary, before attempting to resolve the snapshot target (PVC/PV).
• Remove the later expire calls that could be skipped when getSnapshotTarget fails.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

internal/controller/mantlebackup_controller.go:521

• This early expiration path has the same cleanup gap for secondary backups: if the target PVC is gone, finalization gets targetPVCNotFound=true and skips removeRBDSnapshot, so the MantleBackup can be removed while the imported RBD snapshot remains. Please make the deletion path clean up the snapshot using persisted manifest/status data instead of relying on the live PVC lookup.

	if stopProcessing, err := r.expire(ctx, backup); stopProcessing || err != nil {
		return requeueReconciliation(), err
	}

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

• internal/ceph/ceph_mock.go: Language not supported