filter resources correctly in a multi-controller environment#302
Closed
llamerada-jp wants to merge 4 commits into
Closed
filter resources correctly in a multi-controller environment#302llamerada-jp wants to merge 4 commits into
llamerada-jp wants to merge 4 commits into
Conversation
Replace the (ctrl.Result, error) return convention used throughout MantleBackupReconciler's helper methods with a single *reconcileResult value. reconcileResult encodes exactly one of four outcomes: success, requeue, error, or "continue" (nil), which makes the control flow of each step explicit and removes the need to juggle ctrl.Result and error side by side at every call site. Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
Previously, whether a MantleBackup should be processed by this controller was decided deep in getSnapshotTarget via checkPVCInManagedCluster. Therefore, unnecessary processing was being performed. Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
The local-backup-target-pvc-uid label is now attached in reconcileLocalBackup before provisionRBDSnapshot is called, so attaching the same label again in provisionRBDSnapshot is redundant. Remove it together with the extra Get/Update round-trip it required. Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
add the label for cluster id for CreateOrUpdatePVC request - send cluster id from primary as the label - check it on secondary server when received the request Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, whether a MantleBackup should be processed by this controller was decided deep in getSnapshotTarget via checkPVCInManagedCluster. Therefore, unnecessary processing was being performed.