perf(validation): remove unnecessary sorting on validator hot path#317
Open
dborgards wants to merge 1 commit into
Open
perf(validation): remove unnecessary sorting on validator hot path#317dborgards wants to merge 1 commit into
dborgards wants to merge 1 commit into
Conversation
Iterate object dictionary, sub-objects, and network nodes directly and precompute the allowed-baudrates message once. Fixes #309 Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderByfrom object-dictionary, sub-object, and network-topology validation loopsFixes #309
Test plan
dotnet test --filter FullyQualifiedName~CanOpenModelValidatorTestsMade with Cursor