Customize settings#143
Open
martinxsliu wants to merge 1 commit into
Open
Conversation
eadwinCode
requested changes
Sep 13, 2025
eadwinCode
left a comment
eadwinCode
left a comment
Owner
There was a problem hiding this comment.
There are also failing tests
| token_type: Optional[str] = None | ||
| lifetime: Optional[datetime] = None | ||
| lifetime: Optional[timedelta] = None | ||
| settings: NinjaJWTSettings = api_settings |
Owner
There was a problem hiding this comment.
settings is better off a property than a cls attribute
@property
def ninja_jwt_setting(self) -> NinjaJWTSettings:
return api_settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a class variable
Token.settingswhich defaults toapi_settings. This allows users to define multiple Token classes with different settings, e.g. in cases where we may want to validate against multiple token types.