Fix assistant inline markup rendering#2667
Open
gentlemandev wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize streamed assistant inline markup before rendering so structured email cards do not appear as raw tags in list responses. Also unwrap block-style assistant components from markdown paragraphs to avoid invalid nesting.
Tests:
pnpm exec vitest run components/assistant-chat/assistant-inline-email-response.test.tsx(fails in this environment before assertions withReact.act is not a function)pnpm --filter inbox-zero-ai test -- --run components/assistant-chat/assistant-inline-email-response.test.tsx(mis-forwarded by package script and ran the broader suite; unrelated existing environment failures includeReact.act is not a functionand missing@/utils/hash)Performance impact: Adds small string normalization and child inspection only while rendering assistant responses. No new database or network calls; low hot-path risk because work is scoped to chat response rendering.