NullPointerException while getting list of services has been fixed.

[irbis]

By default KubernetesServerList() initializes with default constructor and then method initWithNiwsConfig(IClientConfig clientConfig) runs.

Default constructor doesn't initialize this.client that leads to NullPointerException in line 67. This has been fixed.

Also, hellohystrix and helloribbon use different keys and looks like this is a reason why ribbon can't find hello-hystrix command.

cc: @iocanel

[irbis]

Hi @iocanel
Is this pull request is usefull?

Thanks,

[sonata82]

Shouldn't client be initialized in the default empty constructor then?

And I'm not sure, but it the default constructor used anyway?

[irbis]

It in use. And this leads to NullPointerException.

[iocanel]

Thanks for sending this in and apologies for the long wait.

[iocanel]

Are there any guarantees that this method will be called only when the object is constructed using the empty constructor? If not, then it can potentially be an issue.

It would be cleaner if we took care of the problem as part of the default constructor.

[irbis]

As far as I tested this, first default constructor runs, then initWithNiwsConfig(). I didn't see any call to other variants of constructors.

To guarantee from issues why not to add check to null:
if (this.client == null) this.client = new DefaultKubernetesClient();

[iocanel]

Can we just move the logic to the default constructor? I think that this is the cleanest possible approach.

[irbis]

I did it. But it didn't work. I could check why, but I need extra time for this.

[iocanel]

The only rational explanation I can think of is the default constructor not being used at all. It could use the non-default ones and pass a null instance of the kubernetes-client.

[irbis]

Ok. Give me a couple of days and I'll attach stack trace.

[irbis]

Hi,
I've checked the code and find out some changes were added after I had created PR. Let's drop my changes.

Thanks