Add decoding processor#7
Conversation
…ween model and real time process
…merger computing only the posterior likelihoods based on all log likelihoods
Comment by @MarineChap on January 14, 2022 at 01:07 PM UTC:
To Remove before merge ! |
|
|
||
| Output port: | ||
| - name: events | ||
| type: ColumnType<double> |
There was a problem hiding this comment.
Comment by @fkloosterman on July 19, 2022 at 12:19 PM UTC:
💬 Code comment on
processors/multilikelihoodsource/doc.yaml(line 11) (commit:388841d)
<double>?
|
|
||
| // VARIABLES | ||
| protected: | ||
| FollowerState<std::map<std::string, std::shared_ptr<PoissonLikelihood>>*> *shared_likelihoods_ ; |
There was a problem hiding this comment.
Comment by @fkloosterman on July 19, 2022 at 12:20 PM UTC:
💬 Code comment on
processors/multilikelihoodsource/multilikelihoodsource.hpp(line 36) (commit:388841d)
call it model_?
| FollowerState<std::map<std::string, std::shared_ptr<PoissonLikelihood>>*> *shared_likelihoods_ ; | ||
| unsigned int grid_size_; | ||
| unsigned int slot_; | ||
| SlotType nslots_; |
There was a problem hiding this comment.
Comment by @fkloosterman on July 19, 2022 at 12:20 PM UTC:
💬 Code comment on
processors/multilikelihoodsource/multilikelihoodsource.hpp(line 39) (commit:388841d)
slot_
| #include "utilities/string.hpp" | ||
|
|
||
| MultiLikelihoodSource::MultiLikelihoodSource(): IProcessor(){ | ||
| add_option("decoding size", delta_t_, "Time bin size for decoding (aka delta_t)."); |
There was a problem hiding this comment.
Comment by @fkloosterman on July 19, 2022 at 12:23 PM UTC:
💬 Code comment on
processors/multilikelihoodsource/multilikelihoodsource.cpp(line 24) (commit:388841d)
doc: “Time bin size for decoding (aka delta_t)”
option name: check other processors - do we use “bin size”? if so, let's be consistent
There was a problem hiding this comment.
Comment by @MarineChap on July 20, 2022 at 01:19 PM UTC:
💬 Code comment on
processors/multilikelihoodsource/multilikelihoodsource.cpp(line 24) (commit:388841d)
Indeed “decoding time” would be more consistent
|
|
||
| MultiLikelihoodSource::MultiLikelihoodSource(): IProcessor(){ | ||
| add_option("decoding size", delta_t_, "Time bin size for decoding (aka delta_t)."); | ||
| } |
There was a problem hiding this comment.
Comment by @fkloosterman on July 19, 2022 at 12:24 PM UTC:
💬 Code comment on
processors/multilikelihoodsource/multilikelihoodsource.cpp(line 25) (commit:388841d)
compute → computed
|
|
||
| } | ||
|
|
||
| void OnlineDecoder::CompleteStreamInfo() { |
There was a problem hiding this comment.
Comment by @fkloosterman on July 19, 2022 at 12:56 PM UTC:
💬 Code comment on
processors/onlinedecoder/onlinedecoder.cpp(line 41) (commit:388841d)
rename port to posterior
| ColumnsType<double>::Data *data_out = nullptr; | ||
| uint64_t hardware_ts; | ||
| std::vector<double> logL; | ||
| bool should_break=false; |
There was a problem hiding this comment.
Comment by @fkloosterman on July 19, 2022 at 12:58 PM UTC:
💬 Code comment on
processors/onlinedecoder/onlinedecoder.cpp(line 57) (commit:388841d)
note: we assume that the upstream decoding model is the same as the decoding model used here
|
marine chaput opened the pull request on January 14, 2022 at 12:59 PM UTC |
|
New commit added to PR: eadb765 by marine chaput on January 14, 2022 at 01:06 PM UTC |
|
New commit added to PR: 58f26e8 by marine chaput on January 14, 2022 at 01:48 PM UTC |
|
New commit added to PR: dac88c8 by marine chaput on January 14, 2022 at 06:18 PM UTC |
|
New commit added to PR: 8f577ff by marine chaput on January 14, 2022 at 09:49 PM UTC |
|
New commit added to PR: ad52578 by marine chaput on January 17, 2022 at 06:18 PM UTC |
|
New commit added to PR: 81ae508 by marine chaput on January 25, 2022 at 12:11 PM UTC |
|
New commit added to PR: 8177f9a by marine chaput on February 10, 2022 at 09:52 AM UTC |
|
New commit added to PR: 810f626 by marine chaput on February 14, 2022 at 07:12 PM UTC |
|
New commit added to PR: 8dc64a9 by marine chaput on February 22, 2022 at 03:48 AM UTC |
|
New commit added to PR: 5ef0814 by marine chaput on March 24, 2022 at 11:39 AM UTC |
|
New commit added to PR: e648ecb02f44 by marine chaput on July 20, 2022 at 01:31 PM UTC |
|
New commit added to PR: 7710ab7 by marine chaput on July 20, 2022 at 01:35 PM UTC |
|
New commit added to PR: 8081c24 by marine chaput on August 23, 2022 at 04:27 PM UTC |
|
New commit added to PR: 67c88fd14a73 by marine chaput on September 09, 2022 at 01:29 PM UTC |
|
New commit added to PR: b04c9ce by marine chaput on September 09, 2022 at 02:07 PM UTC |
|
New commit added to PR: d74e59ee09fd by marine chaput on September 29, 2022 at 09:58 AM UTC |
|
New commit added to PR: 2051a838af5c by marine chaput on October 20, 2022 at 08:51 AM UTC |
|
New commit added to PR: 14d3d4cc29fb by marine chaput on October 25, 2022 at 11:32 AM UTC |
|
New commit added to PR: ced4e1e by marine chaput on November 10, 2022 at 09:32 AM UTC |
|
New commit added to PR: 890bba1 by marine chaput on November 14, 2022 at 01:18 PM UTC |
|
New commit added to PR: a902d98 by marine chaput on November 17, 2022 at 12:28 PM UTC |
|
New commit added to PR: 68a41fa by marine chaput on November 18, 2022 at 10:22 AM UTC |
|
New commit added to PR: e0df57e by marine chaput on November 18, 2022 at 02:58 PM UTC |
|
New commit added to PR: 9d2c526 by marine chaput on November 29, 2022 at 11:13 AM UTC |
|
New commit added to PR: 7960ee1 by marine chaput on December 11, 2022 at 11:12 AM UTC |
|
New commit added to PR: 388841d by marine chaput on December 22, 2022 at 01:22 PM UTC |
1 participant
Migrated from Bitbucket