Fix the oldest_build_allowed parameter use #16
Open
Vkt0r wants to merge 1 commit into
Open
Conversation
* The `oldest_build_allowed` was using the `installed_cf_bundle_short_version_string` instead of the `installed_cf_bundle_version` to compare the build number of a Testflight build. * Update the README to include all the parameters available for the plugin
Author
|
@joshdholtz Any chance you can take a look into this PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there 👋,
Thanks for creating this plugin 🎉, it's very good! This PR is focused on the following areas:
oldest_build_allowedwas using theinstalled_cf_bundle_short_version_string(2.6.1) instead of theinstalled_cf_bundle_version(1542691006) to compare the build number of a Testflight build.READMEto include all the parameters available for the plugin for a better understanding of the plugin use.