[codex] Deflake visitorId e2e assertion#245
Draft
JuroUhlar wants to merge 1 commit into
Draft
Conversation
Contributor
pnpm exec changesetto create a changeset. |
Contributor
Coverage report
Test suite run success273 tests passing in 94 suites. Report generated by 🧪jest coverage report action from 9d9d383 Show full coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<code>result block contains parseable JSON with a valid visitorId/requestId pairWhy
The e2e test was flaky because it read and parsed the result element once after a fixed delay. When the page had rendered the element but had not populated valid JSON yet, the test failed even though the result would appear shortly after.