feat: add gas and skipSimulation params to sendTransaction#46
Conversation
Add optional `gas` (bigint) and `skipSimulation` (boolean) parameters to both sendTransaction and sendTransactionSync across the relayer and account layers, passing them through to the RPC request params. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @pedrocrvz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances transaction functionality by introducing optional Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully adds optional gas and skipSimulation parameters to sendTransaction and sendTransactionSync functions across both relayer and account layers. The changes are well-tested, ensuring that these new parameters are correctly passed through to the RPC requests. The code is clean and follows good practices for parameter handling and type definitions. The new changeset file and example update are also appropriate.
Summary
gas(bigint) andskipSimulation(boolean) parameters tosendTransactionandsendTransactionSyncacross relayer and account layersgasis converted to string)Test plan
pnpm test— 202 tests)pnpm build,tsc --noEmit)gasandskipSimulationare included in RPC params (relayer layer)gasandskipSimulationare passed through to client (account layer)🤖 Generated with Claude Code