Skip to content

feat: add gas and skipSimulation params to sendTransaction#46

Merged
pedrocrvz merged 2 commits into
masterfrom
feat/skip-simulation
Feb 19, 2026
Merged

feat: add gas and skipSimulation params to sendTransaction#46
pedrocrvz merged 2 commits into
masterfrom
feat/skip-simulation

Conversation

@pedrocrvz

Copy link
Copy Markdown
Contributor

Summary

  • Add optional gas (bigint) and skipSimulation (boolean) parameters to sendTransaction and sendTransactionSync across relayer and account layers
  • Values are passed through to the RPC request params (gas is converted to string)
  • Add tests for both new parameters at all layers

Test plan

  • All existing tests pass (pnpm test — 202 tests)
  • Build and type-check pass (pnpm build, tsc --noEmit)
  • New tests verify gas and skipSimulation are included in RPC params (relayer layer)
  • New tests verify gas and skipSimulation are passed through to client (account layer)

🤖 Generated with Claude Code

Add optional `gas` (bigint) and `skipSimulation` (boolean) parameters to both
sendTransaction and sendTransactionSync across the relayer and account layers,
passing them through to the RPC request params.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @pedrocrvz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances transaction functionality by introducing optional gas and skipSimulation parameters. This allows users greater control over transaction execution, enabling them to specify gas limits and bypass simulation checks when desired. The changes are implemented consistently across different layers of the application, ensuring robust and flexible transaction handling.

Highlights

  • New Transaction Parameters: Added optional gas (bigint) and skipSimulation (boolean) parameters to the sendTransaction and sendTransactionSync functions.
  • Layer Integration: These new parameters are integrated across both the relayer and account layers, ensuring consistent functionality.
  • RPC Parameter Handling: The gas parameter is converted from a bigint to a string before being passed to the RPC request, while skipSimulation is passed directly as a boolean.
  • Comprehensive Testing: New tests have been added at all layers to verify that gas and skipSimulation are correctly included in RPC parameters and passed through to the client.
Changelog
  • .changeset/sparkly-rules-yell.md
    • Added a new changeset file to document the feature addition.
  • examples/account/sponsored/src/index.ts
    • Updated the sponsored account example to include the new skipSimulation parameter in a transaction call.
  • src/account/actions/sendTransaction.test.ts
    • Added a test case to verify that gas and skipSimulation parameters are correctly passed through to client.sendTransaction.
  • src/account/actions/sendTransaction.ts
    • Extended the SendTransactionParameters type to include optional gas (bigint) and skipSimulation (boolean) properties.
    • Modified the sendTransaction function to destructure and pass the new gas and skipSimulation parameters to the underlying client call.
  • src/account/actions/sendTransactionSync.test.ts
    • Added a test case to verify that gas and skipSimulation parameters are correctly passed through to client.sendTransactionSync.
  • src/account/actions/sendTransactionSync.ts
    • Modified the sendTransactionSync function to destructure and pass the new gas and skipSimulation parameters to the underlying client call.
  • src/relayer/evm/actions/sendTransaction.test.ts
    • Added a test case to confirm that gas (converted to string) and skipSimulation are correctly included in the RPC parameters for relayer_sendTransaction.
  • src/relayer/evm/actions/sendTransaction.ts
    • Extended the SendTransactionParameters type to include optional gas (bigint) and skipSimulation (boolean) properties.
    • Modified the sendTransaction function to destructure the new parameters and include them in the RPC request, converting gas to a string.
  • src/relayer/evm/actions/sendTransactionSync.test.ts
    • Added a test case to verify that gas (converted to string) and skipSimulation are correctly included in the RPC parameters for relayer_sendTransactionSync.
  • src/relayer/evm/actions/sendTransactionSync.ts
    • Modified the sendTransactionSync function to destructure the new parameters and include them in the RPC request, converting gas to a string.
Activity
  • The author has confirmed that all existing tests pass (202 tests).
  • The author has verified that build and type-check processes pass.
  • The author has added new tests to confirm gas and skipSimulation are correctly included in RPC params at the relayer layer.
  • The author has added new tests to confirm gas and skipSimulation are passed through to the client at the account layer.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds optional gas and skipSimulation parameters to sendTransaction and sendTransactionSync functions across both relayer and account layers. The changes are well-tested, ensuring that these new parameters are correctly passed through to the RPC requests. The code is clean and follows good practices for parameter handling and type definitions. The new changeset file and example update are also appropriate.

@pedrocrvz pedrocrvz merged commit 7d07f28 into master Feb 19, 2026
3 checks passed
@pedrocrvz pedrocrvz deleted the feat/skip-simulation branch February 19, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant