Implementing writable to matrix#2033
Open
JEFFjeffJJ wants to merge 2 commits into
Open
Conversation
yhmtsai
requested changes
Jun 16, 2026
yhmtsai
left a comment
yhmtsai
left a comment
Member
There was a problem hiding this comment.
the current implementation is good if we have row_map.
I need to think/discuss the row_map with others first.
The constructor assumes the row and col partition are the same but it is not always true.
The test will also need more cases such as row and col partition are different
| exec, comm, local_linop->get_size()[0])); | ||
| row_map_ = index_map<local_index_type, global_index_type>( | ||
| exec, partition, comm.rank(), array<global_index_type>{exec}); | ||
| imap_ = row_map_; |
Member
There was a problem hiding this comment.
colmap should use another partition from get_size()[1] unless they are equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.