Fixed can't selected outEnd for pie charts#1336
Open
rvntone wants to merge 1 commit into
Open
Conversation
shbernal
added a commit
to shbernal/PptxGenJS
that referenced
this pull request
Jun 8, 2026
- Remove stray apostrophe from embedded workbook table ref attribute, fixing chart rendering in Apple Keynote (gitbrent#1327, gitbrent#1306, gitbrent#1242) - Pie/doughnut parent dLbls block now respects dataLabelPosition instead of always hard-coding "ctr" (gitbrent#1336, gitbrent#1368) - Shadow blur/angle/opacity use nullish coalescing so zero values are honoured rather than replaced by defaults (gitbrent#1366) - barOverlapPct is checked before the stacked-bar forced-100 fallback, allowing callers to override overlap on stacked bar charts (gitbrent#1257) - Scatter/bubble cat-axis reads catAxisLabelPos instead of hard-coding "nextTo" (gitbrent#976) - Add 'maxMin' to catAxisOrientation and valAxisOrientation type unions; XML emission was already correct (gitbrent#1269, gitbrent#1187)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you try to select outEnd for the dataLabelPosition attribute, it always sets one of the 4 values on the xml as a ctr.