fix: GCS signing issue#2920
Open
szuro wants to merge 1 commit into
Open
Conversation
As described here: aws/aws-sdk-go-v2#1816 (comment)
github-actions
Bot
added
the
area/attachments
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-2920
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-2920Last updated for commit f851e6f |
Member
|
Please fix the lint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are signing issues when using Google Cloud Storage as an S3 backend.
For whatever reason, GCS modifies
Accept-Encodingheader.This causes Vikunja to fail even with
files.s3.disablesigning: trueThe maintainers of aws-sdk-go refuse to address this, hence this PR.
More details can be found here: aws/aws-sdk-go-v2#1816 (comment)