feat(projects): make duplicating shares opt-in#2932
Merged
Conversation
When duplicating a project, user, team and link shares are no longer copied by default. Set the new duplicate_shares flag to true to copy them. The frontend duplicate dialog gains a checkbox (pre-checked) so the default UX is unchanged.
github-actions
Bot
added
area/api
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-2932
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-2932Last updated for commit bf175dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicating a project always copied its user, team and link shares, with no way to opt out — so a copy meant for personal use silently inherited every collaborator and public link.
Shares are now only copied when the new
duplicate_sharesflag is set (defaults tofalse). This applies to both/api/v1and/api/v2, which share the model. The frontend duplicate dialog gains a checkbox, pre-checked, so the default UX is unchanged.Test plan