fix: close HTTP response bodies to prevent OOM with many checks#1058
Open
dukelion wants to merge 1 commit into
Open
fix: close HTTP response bodies to prevent OOM with many checks#1058dukelion wants to merge 1 commit into
dukelion wants to merge 1 commit into
Conversation
Contributor
|
Hi! I fixed the integration test pipelines recently. Could you rebase or merge from master? I checked you integration test failures, and most if not all of them would be fixed by that. |
When running 100+ HTTP checks concurrently, response bodies were never closed if the check only validated status and headers (no body matcher). This caused unclosed TCP connections to accumulate, holding TLS state and transport buffers until the 10s client timeout expired, leading to OOM kills under memory limits. Changes: - Add Close() to system.HTTP interface and DefHTTP - Track whether Body() consumed the response body - Close() closes resp.Body if it wasn't consumed (i.e. status/headers-only checks) - resource/http.go Validate() defers sysHTTP.Close() for guaranteed cleanup Fixes OOM when goss is configured with many HTTP checks and limited RAM.
dukelion
force-pushed
the
fix/http-oom-response-body-cleanup
branch
from
54592bc to
b13b130
Compare
Author
|
Rebased this branch onto current I also tightened the cleanup path so Local validation run on Windows:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running 100+ HTTP checks concurrently, response bodies were not always closed after validation. This caused unclosed TCP connections to accumulate, holding TLS state and transport buffers until the client timeout expired, leading to OOM kills under memory limits.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Fixes OOM when goss is configured with many HTTP checks and limited RAM.
Close()to thesystem.HTTPinterface andDefHTTPsysHTTP.Close()from HTTP resource validation for guaranteed cleanupresp.BodywhenClose()is called, including after a body matcher reads it