Fix emotion template literal minification#16197
Merged
Merged
Conversation
Jakeii
force-pushed
the
jlk/fix-emotion-template-literal-2
branch
from
159366f to
6e48705
Compare
github-actions
Bot
removed
the
run_chromatic
Jakeii
force-pushed
the
jlk/fix-emotion-template-literal-2
branch
from
6e48705 to
04113fe
Compare
github-actions
Bot
removed
the
run_chromatic
Jakeii
commented
Jun 18, 2026
| }; | ||
|
|
||
| const liveBlockContainerStyles = () => css` | ||
| const liveBlockContainerStyles = css` |
Member
Author
There was a problem hiding this comment.
Not entirely sure how this even worked before, but it doesn't with the swc plugin!
This function wasn't called when used down on line 161
Jakeii
changed the title
github-actions
Bot
removed
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fixed version of #16184
Which had to be reverted, as there were some unexpected visual changes which weren't flagged by chromatic due to an earlier change that also had to be reverted.
What does this change?
Add the
@swc/plugin-emotionpluginWhy?
emotioncss using the template literal syntax does not get minified without a babel or swc plugin.Screenshots