fix(core): make day conversion deterministic#20
Open
dearlordylord wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor priority. This issue popped up when I was working on #19 (I'm not in London, as you can guess! 😄 ) (although there is A London, Ontario in my timezone!)
Summary
getDay/convertToDayindependent of the Node process timezoneEurope/London, then normalize it to noon UTCAmerica/Los_AngelesNotes
The previous implementation mixed local-time day reads with UTC writes, so the same timestamp could normalize to different days depending on where the tests ran. The existing tests already used
Europe/Londonas the expected day, but they failed under non-London process timezones because the implementation depended on localDatebehavior.Test plan
TZ=America/Los_Angeles node common/scripts/install-run-rush.js retest --to @hcengineering/coreTZ=Europe/London node common/scripts/install-run-rush.js retest --to @hcengineering/corenode_modules/.bin/eslint src/time.ts src/__tests__/time.test.tsnode_modules/.bin/tsc --noEmit --pretty false