docker compose fallback to the legacy docker-compose#1223
Open
veyselsahin wants to merge 3 commits into
Open
Conversation
lukemarsden
reviewed
Aug 11, 2025
Collaborator
|
Thanks for the PR! I left one comment |
93e4998 to
c07feb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Ubuntu 24.04 with the docker.io package,
docker compose(Compose v2plugin) is not installed by default, but the legacy
docker-composebinary is available and works.
The current install.sh assumes that if
docker compose versionfails,Compose is not installed at all, and unconditionally tries to install
the docker-compose-plugin. This can fail in two ways:
Ubuntu's docker-buildx from docker.io.
Even if the install succeeds, final user instructions always print
docker compose ..., which fails on systems that only have the legacybinary.
Fix:
$DOCKER_CMD composebut falls back to
docker-composeif available.$COMPOSE_CMDfor the plugin check and in final instructions.This avoids unnecessary installs, prevents package conflicts, and makes
the installer work on both Docker's official packages and Ubuntu's
docker.io defaults.