feat: if data has URL display it as hyperlink#140
Open
medjedovicm wants to merge 2 commits into
Open
Conversation
allanbowe
approved these changes
Apr 25, 2023
RamonFlyboysGames
approved these changes
May 9, 2023
RamonFlyboysGames
left a comment
RamonFlyboysGames
left a comment
There was a problem hiding this comment.
Minor comment but I also want the feautre.
| private isLink(value: string): boolean { | ||
| return value.substring(0, 8) === 'https://' || | ||
| value.substring(0, 7) === 'http://' || | ||
| value[0] === '/' |
There was a problem hiding this comment.
What if this is changed to a RegExp, the scheme is not case sensitive, and is also posible http:(domain)
Reference
Author
There was a problem hiding this comment.
Sorry, I was delayed a bit. I pushed and would appreciate your review.
Author
|
|
|
I needed this feature (and other proposed features) for my own work, and ended up forking the project and modernizing it. I implemented url/link following, with the ability to override/provide custom "click handling" as desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #131, resolves #132
Implementation
linksegmentLinkClickedpayload is typestringcontaining the clicked segmentvalue