Skip to content

Allow for multiclass classification#11

Open
iKintosh wants to merge 1 commit into
jlloh:mainfrom
iKintosh:main
Open

Allow for multiclass classification#11
iKintosh wants to merge 1 commit into
jlloh:mainfrom
iKintosh:main

Conversation

@iKintosh

Copy link
Copy Markdown

Hi,
I noticed that this binding works only with binary classification. I added small change to allow for multiclass classification.
Ideally it should put vec! inside vec!, but it requires changes in a couple of places as well.

@iKintosh iKintosh mentioned this pull request Jun 30, 2024
@jlloh

jlloh commented Jun 30, 2024

Copy link
Copy Markdown
Owner

Hello, thank you for your contribution!

  1. Would it be possible to add some unit basic tests for multiclass classifications?
  2. We should probably bump the package version in Cargo.toml ?
  3. Perhaps also worth starting a changelog.md file, I can add one and you can rebase from master and add your changes to the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants